fix vulns + upgrade eslint to latest #1183
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juanri0s
commented
Jan 29, 2026
Comment on lines
-6
to
-10
| ## [5.0.6](https://github.com/C2FO/fast-csv/compare/v5.0.5...v5.0.6) (2025-12-22) | ||
|
|
||
| ### Security | ||
|
|
||
| - **deps:** update @docusaurus/core and @docusaurus/preset-classic to v3.9.2 to resolve security vulnerabilities |
Contributor
Author
There was a problem hiding this comment.
i believe publishing does this, and we havent published since 5.0.5. probably a mistake in my last pr
| import tsdoc from 'eslint-plugin-tsdoc'; | ||
| import eslintConfigPrettier from 'eslint-config-prettier'; | ||
|
|
||
| export default defineConfig([ |
Contributor
Author
There was a problem hiding this comment.
opted to just get to latest eslint for some vulns which is now a flat config file
Pull Request Test Coverage Report for Build 21486106670Details
💛 - Coveralls |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the linting/tooling stack (ESLint + TypeScript-ESLint), refreshes dependency locks to address vulnerabilities, and cleans up various inline lint suppressions and metadata.
Changes:
- Replace legacy
.eslintrc.js+.eslintignorewith a flateslint.config.mjsusing ESLint 9, TypeScript-ESLint 8, Prettier, and updated linting rules for TypeScript sources, tests, and JS examples. - Update lint npm scripts and devDependencies (
eslint,@eslint/js,@typescript-eslint/*,typescript-eslint,globals, etc.), alongside a largepackage-lock.jsonrefresh that pulls in newer transitive versions and example/package-local dependencies. - Minor code/test cleanups (removal of now-unnecessary
eslint-disablecomments, small formatting adjustments), plus metadata tweaks (LICENSE year, changelog header toUnreleased, bug report assignees, Node version in.tool-versions).
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/parse/src/transforms/RowTransformerValidator.ts |
Removed redundant eslint-disable for no-shadow on a static generic helper; no behavioral changes. |
packages/parse/src/transforms/HeaderTransformer.ts |
Removed obsolete no-param-reassign suppression around header-row mapping; runtime behavior unchanged. |
packages/parse/__tests__/parser/Scanner.spec.ts |
Dropped inline no-non-null-assertion disable comments while keeping test logic intact. |
packages/parse/__tests__/CsvParsingStream.spec.ts |
Simplified a promise-returning stream pipeline chain and removed an unnecessary no-empty-function suppression; semantics preserved. |
packages/format/src/formatter/RowFormatter.ts |
Removed no-shadow suppression on createTransform generic helper; formatter behavior unchanged. |
packages/format/__tests__/formatter/RowFormatter.spec.ts |
Removed an unused-var suppression where the function is actually used; test behavior unchanged. |
package.json |
Switched lint scripts to use the flat config (eslint "**/*.ts" ...), upgraded ESLint/TS-ESLint/Prettier-related devDependencies, and added the typescript-eslint meta package and globals. |
package-lock.json |
Regenerated to align with new devDependency versions, updating many transitive packages (ESLint 9 stack, lodash, tar, etc.) and adding lock entries for examples and package-local deps. |
eslint.config.mjs |
New flat ESLint config wiring up @eslint/js, typescript-eslint (recommended + type-checked for .ts), Prettier, import/jest/tsdoc plugins, test-specific relaxations, and focused JS example linting. |
LICENSE |
Updated copyright year from 2025 to 2026. |
CHANGELOG.md |
Replaced a future-dated 5.0.6 section with a neutral ## [Unreleased] heading to reflect current unreleased state. |
.tool-versions |
Added explicit nodejs 20.19.0 to match new minimums implied by ESLint 9 / TS-ESLint 8. |
.github/ISSUE_TEMPLATE/bug_report.md |
Updated default assignees to remove one inactive maintainer. |
.eslintrc.js |
Removed legacy ESLint config now superseded by the flat eslint.config.mjs. |
.eslintignore |
Removed legacy ignore file; equivalent patterns are now handled via the flat config’s ignores entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
New Feature Submissions:
Changes to Core Features: