[BEN-174] Add Favorite Icon to Medicare Package#3946#3949
Open
kamiTT wants to merge 5 commits intoCMSgov:mainfrom
Open
[BEN-174] Add Favorite Icon to Medicare Package#3946#3949kamiTT wants to merge 5 commits intoCMSgov:mainfrom
kamiTT wants to merge 5 commits intoCMSgov:mainfrom
Conversation
Collaborator
tamara-corbalt
left a comment
There was a problem hiding this comment.
Just two small nitpicks — otherwise this looks great!
packages/ds-medicare-gov/src/components/Icons/icons.stories.tsx
Outdated
Show resolved
Hide resolved
tamara-corbalt
approved these changes
Mar 2, 2026
Collaborator
tamara-corbalt
left a comment
There was a problem hiding this comment.
LGTM, preemptively approving while CI runs.
After CI passes, let’s be sure to tag this PR with a milestone (probably 14.0.0) and add:
- Impacts: Medicare
- Type: Changed
| name: 'RoundedStarIcon', | ||
| notes: | ||
| 'Takes a `variation` prop to determine if the star is fully filled, half filled, or just an outline.', | ||
| 'Takes a <code>variation</code> prop to determine if the star is fully filled, half filled, or just an outline.', |
Contributor
Author
I personally cannot add any tags to the PR |
Collaborator
Oh gotca, I've added them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ticket
Adding a new icon that CXT uses within their application: heart
How to test
HeartIcon,HeartEmptyIcon,HeartFilledIconChecklist
[CMSDS-####] Titleor [NO-TICKET] if this is unticketed work.Type(only one) label for this PR, if it is a breaking change, label should only beType: BreakingImpacts, multiple can be selected.If this is a change to design:
If this is a change to code:
npm run test:unitandnpm run test:browser:allwere each successfulnpm run test:unit:update) and browser-test snapshots (npm run test:browser:all:update)If this is a change to documentation/content: