some optimization for the main.cc code #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some optimization for the main.cc code. 1. add __device__ and __restrict__ decoration for style uniform and performance. 2. an error in function call, in line: cudaMemcpyToSymbol(&cFoo, &bar, sizeof(int)); the first parameter should be pointer type. 3. Hope you can send me your book. :)
delete the __device__
we already input N/2 in kernel launch function point, if we divide/2 here, the result is always wrong, seems half of the original result.
asimay
commented
Aug 14, 2023
Author
There was a problem hiding this comment.
sorry, maybe the line 76: cudaMemcpyToSymbol(&cFoo, &bar, sizeof(int)); modification is wrong.
please ignore this line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some optimization for the main.cc code.
thanks.