Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jmwright
Copy link
Member

@jmwright jmwright commented Feb 1, 2025

@jdegenstein You may already have something done on this. We can discuss how to get this functionality into the codebase, but I want to try some things out in this PR.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.92%. Comparing base (d746c8e) to head (02a7343).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
cq_editor/cqe_run.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   89.26%   88.92%   -0.34%     
==========================================
  Files          19       20       +1     
  Lines        1583     1589       +6     
  Branches      157      159       +2     
==========================================
  Hits         1413     1413              
- Misses        139      145       +6     
  Partials       31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmwright
Copy link
Member Author

jmwright commented Feb 1, 2025

This works fine and installs a CQ-editor script just like the conda package does. CQ-editor works fine when passed a filename to open on the command line, but is trying to do something with test_app.py when no filename is passed and adds an error related to test_modulefinder in the log viewer. This only seems to happen the very first time it is run after being installed. Otherwise this pyproject.toml seems to work well, and even builds a working wheel, at least on Debian 12.

@jmwright jmwright changed the title Experimenting with pyproject.toml Adding pyproject.toml Feb 2, 2025
@jmwright
Copy link
Member Author

jmwright commented Feb 2, 2025

The bug with the editor filename was related to the Qt settings being polluted after I had run the tests locally. I also removed the faulthandler from the script to launch the pip installed version since a normal user does not need to see debugging output. I left those lines in run.py so that developers would still get debugging.

@jdegenstein Let me know what you think of this PR. It seems to work well when testing on my local machine.

@jmwright jmwright marked this pull request as ready for review February 3, 2025 00:25
@jmwright jmwright merged commit 0232d0a into master Feb 4, 2025
7 of 9 checks passed
@jmwright jmwright deleted the pypi branch February 4, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant