Fix rare crash resulting from splitting of bent quads and fix corruption from too strict coplanarity check #3439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y broad assumptions I made about the possible configurations of the quads.
…er surface "siblings" which were actually also in the split plane, leading to corruption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made an overly broad assumption that was violated by a very specific arrangement of the split plane and a bent quad. See the fixed issue for more details.
Fixes #3436
Also fixes corruption resulting from a too strict coplanarity check when filtering candidate quads for those which lie on the split plane. It was not checking for quads whose normal and dot product are inverted but otherwise equal to the split plane.
Fixes #3279