Thanks to visit codestin.com
Credit goes to github.com

Skip to content

improvement: Hide Windows App Settings Group #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2025
Merged

improvement: Hide Windows App Settings Group #954

merged 2 commits into from
Aug 26, 2025

Conversation

ameer2468
Copy link
Collaborator

@ameer2468 ameer2468 commented Aug 26, 2025 •
edited by coderabbitai bot
Loading

This PR: On Windows we render the group "App" settings when it has none, so with this change we're conditionally rendering.

Summary by CodeRabbit

  • New Features

    • Settings now adapt to your operating system: OS-specific groups and items only appear when relevant.
    • On macOS, the App settings (Hide dock icon, Enable system notifications, Enable haptics) are shown; these are hidden on Windows and Linux.
    • Non-OS-specific groups (e.g., Cap Pro, Recording) remain visible across all platforms.

  • Refactor

    • Streamlined the settings rendering flow to gate entire groups by OS, improving clarity and reducing irrelevant options for users.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 26, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces OS-scoped settings groups in the desktop settings page. Adds an optional os field to SettingsGroup, marks the App group and its items as macOS-only, and refactors rendering to gate groups by OS while preserving per-item OS checks and existing select-item rendering.

Changes

Cohort / File(s) Summary
OS-scoped settings and rendering refactor
apps/desktop/src/routes/(window-chrome)/settings/general.tsx		 - Added optional os?: "macos" | "windows" | "linux" to SettingsGroup type
- Marked App group and its items with os: "macos"
- Wrapped each group in OS-gated Show based on current ostype
- Preserved per-item OS checks inside groups
- Maintained select-item rendering via existing helper
- Non-OS-scoped groups unchanged; minor markup restructuring within Show/For

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant SettingsPage
  participant Groups as SettingsGroups
  participant OSFilter as OS Gate
  participant ItemRenderer

  User->>SettingsPage: Open General Settings
  SettingsPage->>Groups: Iterate groups (For)
  loop For each group
    SettingsPage->>OSFilter: Check group.os vs ostype
    alt Group allowed (os matches or undefined)
      OSFilter-->>SettingsPage: Render group
      SettingsPage->>ItemRenderer: Iterate items (For)
      alt Item allowed (os matches or undefined)
        ItemRenderer-->>User: Render item (toggle/select)
      else Item blocked
        ItemRenderer-->>ItemRenderer: Skip item
      end
    else Group blocked
      OSFilter-->>SettingsPage: Skip group
    end
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I twitch my ears at platform signs,
Mac-only carrots in tidy lines.
Groups now hop through OS gates,
While items check their destined states.
Selects still spin like lunar wheels—
A gentle refactor, fewer peels.
Thump! The settings burrow feels right. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 12a6e25 and 64c3ab8.

📒 Files selected for processing (1)
  • apps/desktop/src/routes/(window-chrome)/settings/general.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch group-render-os

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ameer2468 ameer2468 merged commit 3a0f58a into main Aug 26, 2025
13 of 14 checks passed
@ameer2468 ameer2468 deleted the group-render-os branch August 26, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ameer2468