Locate schemes concurrently#3076
Merged
elliottwilliams merged 3 commits intoFeb 26, 2021
Merged
Conversation
Contributor
Author
|
@tmspzz take a look if you've still got bandwidth. FWIW, my team has been using this in production for a couple months w/o issues. |
Member
|
LGTM |
tmspzz
approved these changes
Feb 24, 2021
elliottwilliams
added a commit
to elliottwilliams/Carthage
that referenced
this pull request
Jul 13, 2021
In Carthage#3076, we started loading projects concurrently to speed up scheme selection in repos containing multiple projects. This introduced a race condition where Carthage would consider whichever project loaded _first_ to be the optimal project to build from, instead of using the sorted order of `ProjectLocator` objects. Fixed by re-sorting the project-scheme pairs that are emitted in `buildableSchemesInDirectory`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In large repos (repos with many xcode projects in them, or repos with deeply nested directories),
buildableSchemesInDirectorycan become noticeably slow.This change makes the directory enumerator stop descending when we filter out a URL, and calls
xcodebuild -listconcurrently using the same pattern that Carthage uses further down.