Heading inside complex field has strong applied #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
You have a testcase named HyperlinkFieldCodeTestCase in this module, so wouldn't calling this HeadingFieldCodeTestCase be more consistent?
There was a problem hiding this comment.
Maybe I should rename the other class to drop the FieldCode, since the module is test_field_code?
|
Looks good, other than the test name and code comment suggestion. |
|
Also, I'm pretty sure this will save cleaners a lot of time. I hear often about how it's a pain to de-bold things if it comes in as a heading and it shouldn't be. |
This isn't a bug that is currently present in PolicyStat. This was introduced in v0.9.0 which hasn't gone live for us yet. |
…and also to make adding additional post-first pass processing easier
kylegibson-rldatix
added a commit
that referenced
this pull request
Sep 23, 2015
Heading inside complex field has strong applied
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, the current output is:
The desired output is
This still works for non-complex field runs but is currently broken for complex field runs.