Add playwright snapshots#13458
Open
jjspace wants to merge 3 commits into
Open
Conversation
Contributor
|
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
b23a739 to
af59516
Compare
3348910 to
bb785e6
Compare
Member
|
Apologies it will be a few days before I can get to this review! I'm happy deferring to another reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #13457. That PR improves robustness, this PR includes snapshots to the repo for people to use when running the tests. I think we're close to a point where tests should be mostly stable enough to perform the same across platforms. I spent some extra time using the Playwright UI (
npm run test-e2e -- --ui) to target specific tests and make sure the snapshot generated is actually a good one. There will still need to be updates to some but I feel these are a solid starting place.If we ever want to start running Playwright in CI (#12355) this will be required so we should start identifying which tests are good and which are commonly causing issues.
Issue number and link
Part of #12355
Testing plan
npm run test-e2e -- --uiAuthor checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
If yes, I used the following Model(s):