Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add playwright snapshots#13458

Open
jjspace wants to merge 3 commits into
more-robust-playwrightfrom
add-playwright-snapshots
Open

Add playwright snapshots#13458
jjspace wants to merge 3 commits into
more-robust-playwrightfrom
add-playwright-snapshots

Conversation

@jjspace
Copy link
Copy Markdown
Contributor

@jjspace jjspace commented Apr 30, 2026

Description

Follow up to #13457. That PR improves robustness, this PR includes snapshots to the repo for people to use when running the tests. I think we're close to a point where tests should be mostly stable enough to perform the same across platforms. I spent some extra time using the Playwright UI (npm run test-e2e -- --ui) to target specific tests and make sure the snapshot generated is actually a good one. There will still need to be updates to some but I feel these are a solid starting place.

If we ever want to start running Playwright in CI (#12355) this will be required so we should start identifying which tests are good and which are commonly causing issues.

Issue number and link

Part of #12355

Testing plan

  • Before checking out this branch Move/back up your existing snapshots if you want to keep them.
  • Check out this branch and run npm run test-e2e -- --ui
  • Test a number of tests through the UI (or all if you have ~20-25 min) and make sure they pass using the snapshots in this branch
    • Some may fail, this is unfortunately still expected, try re-running them a few times. if they still fail, report it here and we can look into it

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

AI acknowledgment

  • I used AI to generate content in this PR
  • If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

If yes, I used the following Model(s):

@jjspace jjspace requested review from donmccurdy and jjhembd April 30, 2026 22:09
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

@jjspace jjspace force-pushed the more-robust-playwright branch from b23a739 to af59516 Compare April 30, 2026 22:25
@donmccurdy
Copy link
Copy Markdown
Member

Apologies it will be a few days before I can get to this review! I'm happy deferring to another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants