3dgs spz worker#13490
Open
WilliamLiu-1997 wants to merge 3 commits into
Open
Conversation
Contributor
|
Thank you for the pull request, @WilliamLiu-1997! ✅ We can confirm we have a CLA on file for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR moves SPZ decoding for Gaussian Splat content off the main thread and into a task processor worker.
Previously, loading SPZ-compressed Gaussian Splat tiles could cause severe main-thread stalls. The expensive work included:
@spz-loader/coreUint32Arraybuffers for shader/texture useFor large tiles, especially tiles with SH degree 2 or 3, this could block rendering and make camera interaction freeze or stutter while tiles were loading.
This change adds a
decodeSpzworker and routes SPZ decoding throughGltfSpzDecoder. The worker now decodes the SPZ buffer, packs spherical harmonics data, transfers decoded typed arrays back to the main thread, and stores the packed SH data on model attributes soGaussianSplat3DTileContentcan consume it without doing the packing work on the main thread.Issue number and link
Fixes #13489
Testing plan
Tested by loading Gaussian Splat tiles with spherical harmonics data and navigating while tiles streamed in.
Before this change:
After this change:
decodeSpzworker.GaussianSplat3DTileContent.Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my changeAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
ChatGPT
If yes, I used the following Model(s):
GPT-5.5 Extra-High