Merged
Conversation
Addresses #103. Documents the NaN sentinel approach for rendering disconnected line/area segments via null entries in data arrays.
12-task TDD plan covering types, option resolution, shader NaN detection, data pipeline, example page, acceptance tests, and docs.
The connectNulls filtering used Array.isArray() as a guard, which returned false for MutableXYColumns (XYArraysData) after the coordinator converts DataPoint[] to columnar format. Added filterGaps() that handles all CartesianSeriesData formats. Replaced the minimal line-gaps dev example with a realistic exchange-gaps showcase using crypto price data with maintenance windows.
Normalize multi-asset chart to % change so ETH and SOL share the same y-axis scale. Fix connectNulls toggle losing xAxis/yAxis/dataZoom config on setOption(). Add null gaps highlight to README.
These files were committed before the gitignore entry was added. The .gitignore already excludes docs/plans/ — local copies preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement line and area segmentation via
nulldata entries with aconnectNullsoption, including core data-path changes, shaders, documentation, examples, and acceptance tests.[page:1]Changes
nullgaps +connectNulls).[page:1]CartesianSeriesDatatypes to acceptnullentries for line and area series.[page:1]connectNullsoption on line/area series and resolve it in option resolution.[page:1]line-gapsacceptance test that validates null-gap detection, filtering, bounds computation, option resolution, and sampling bypass behavior.[page:1]exchange-gapsexample (HTML + TS) to demo exchange maintenance gaps,connectNullstoggle, multi-asset outages, and trading session concatenation.[page:1]connectNullsindocs/api/options.mdand surface the feature in the README and examples index.[page:1]connectNullsworks with both array and columnar data formats and fix columnar handling where necessary.[page:1]exchange-gapsexample readability and drop internal docs/plans from tracking.[page:1]Type of Change
Related Issues
Closes #103