Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies single quote handling by removing escape sequences for single quotes in the Cirru writer and formatter, while maintaining backward compatibility in the parser. The version is bumped from 0.2.0 to 0.2.1.
- Removes
\'escape sequence generation in writer functions since single quotes are already allowed in identifiers - Maintains backward compatibility by keeping parser support for
\'escape sequences - Adds comprehensive tests to verify single quote behavior with and without spaces
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/writer.rs | Removes single quote escape handling in generate_leaf() function |
| src/primes.rs | Removes single quote escape handling in escape_cirru_leaf() function |
| tests/writer_test.rs | Adds two new tests verifying single quotes work unquoted without spaces and require quotes with spaces |
| tests/parser_test.rs | Minor formatting improvements to condense multi-line assertions |
| examples/test_escape_debug.rs | Consistent indentation formatting throughout the example file |
| Cargo.toml | Version bump from 0.2.0 to 0.2.1 |
| Cargo.lock | Corresponding version update to 0.2.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.