docs: document mock-bank network isolation and sync env template#22
Merged
Conversation
Add the mock-bank external-network isolation note (the feature merged in PR #20/#21) to all three README language sections, and add the missing SP_PAYMENT_REDIRECT_URL var to .env.example so it matches docker-compose.yml and the README env table. Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings the README and env template up to date with the mock-bank network-isolation feature (merged in #20/#21) that was documented in
CLAUDE.md/docker-compose.ymlbut missing from user-facing docs.externalDocker network and cannot reach the internal datastores (PostgreSQL / Redis / RabbitMQ / MongoDB).SP_PAYMENT_REDIRECT_URLvar (already referenced bydocker-compose.ymland listed in the README env table) so all three sources are consistent.Docs/config only — no application code changed.
Verification
pom.xml(Spring Boot 4.0.5),docker-compose.yml(ports, services, PostgreSQL 14, Alertmanager SMTP),.env.example, andscripts/— everything else was already accurate.wallet_system/srcchanges).🤖 Generated with Claude Code