Add support for MQTT LWT #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky-sharma
requested changes
Mar 6, 2024
setup.py
Outdated
| version='2.4.5', | ||
| description='A Python SDK for interacting with the ClearBlade Platform.', | ||
| url='https://github.com/ClearBlade/ClearBlade-Python-SDK', | ||
| download_url='https://github.com/ClearBlade/ClearBlade-Python-SDK/archive/v2.4.4.tar.gz', |
There was a problem hiding this comment.
@savfaire unfortunately in this old file we were used to changing the version in two places: where you did above, and before the .tar.gz. Maybe this is a good time to make this smarter and use the version to build the path to the tar.gz. Can you go ahead?
|
I’ll look into it.
On Mar 6, 2024, at 5:50 PM, akash-sharma-ext-clearblade ***@***.***> wrote:
@sky-sharma requested changes on this pull request.
________________________________
In setup.py<#30 (comment)>:
@@ -4,7 +4,7 @@
name='clearblade',
packages=['clearblade'],
install_requires=['requests', 'paho-mqtt>=1.3.0'],
- version='2.4.4',
+ version='2.4.5',
description='A Python SDK for interacting with the ClearBlade Platform.',
url='https://github.com/ClearBlade/ClearBlade-Python-SDK',
download_url='https://github.com/ClearBlade/ClearBlade-Python-SDK/archive/v2.4.4.tar.gz',
@savfaire<https://github.com/savfaire> unfortunately in this old file we were used to changing the version in two places. Where you did and before the .tar.gz. Maybe this is a good time to make this smarter and use the version to build the path to the tar.gz. Can you go ahead?
—
Reply to this email directly, view it on GitHub<#30 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABFUBRQ2Y5MU5G2J233AQ23YW6TUNAVCNFSM6AAAAABEJ6Q77WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRRGA2TAMRZG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
sky-sharma
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.