fix issue where only the last collection was being created; handle er… #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors for collection create; short-circuit the import early to make it faster to test; add sleeps to simulate a slow network
clarkbynum
commented
Jan 10, 2023
| fmt.Printf(" %s\n", collection["name"].(string)) | ||
| pool.Submit(func() { | ||
| if info, err := CreateCollection(systemInfo.Key, collection, config.ImportRows, client); err == nil { | ||
| group.Submit(func() error { |
There was a problem hiding this comment.
After glancing over the pond docs, creating a group seemed like the only way you can handle errors
clarkbynum
commented
Jan 10, 2023
| group, _ := pool.GroupContext(context.Background()) | ||
|
|
||
| for _, collection := range collections { | ||
| collection := collection |
There was a problem hiding this comment.
Looking at pond's docs, I noticed that their examples reassign the loop variable so that it stays in scope when the Submit callback is called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rors for collection create; short-circuit the import early to make it faster to test; add sleeps to simulate a slow network