Fix tripolar reductions#5099
Merged
Merged
Conversation
glwagner
reviewed
Jan 5, 2026
Fill halo region and compute velocities from streamfunction.
…ns.jl into ss/correct-tripolar-red
…ns.jl into ss/correct-tripolar-red
Collaborator
Author
|
I think the whitespace check might be allucinating here (or I might be allucinating). I cannot find the whitespaces that it points to! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5099 +/- ##
==========================================
- Coverage 73.97% 73.84% -0.14%
==========================================
Files 400 401 +1
Lines 22870 22938 +68
==========================================
+ Hits 16918 16938 +20
- Misses 5952 6000 +48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
Adapted to the new changes merged in #5408. This should be ready to go @briochemc |
Clarified comments regarding reduction operations for tripolar grids and noted limitations for UPivot distributed tripolar grids.
glwagner
approved these changes
Jun 12, 2026
…ns.jl into ss/correct-tripolar-red
navidcy
referenced
this pull request
Jul 1, 2026
* fix instabilities * Improve documentation for GridSize struct Refactor comments for clarity and readability. * Apply suggestion from @simone-silvestri * Apply suggestion from @simone-silvestri * Apply suggestion from @simone-silvestri * launch a split map * add Sz to the Reactant grid * fix whitespace * make sure also worksize is also inferred * make sure we can infer the constants * add inference tests, compact bounds * Import additional utilities in test_memory_allocation.jl * test we can actually infer the work layout * some changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes reductions on a tripolar grid to make sure that the extra repeated half-line is excluded from the reduction.
This should also solve the problem with the tripolar conservation test.
closes #4488 #4487