Update on_architecture for MetalGPU to specifically target StepRangeLen{FT, Float64, Float64}#5375
Merged
Conversation
Convert StepRangeLen with Float64 to Float32 for Metal architecture
StepRangeLen{Float32, Float64, Float64}
StepRangeLen{Float32, Float64, Float64}StepRangeLen{FT, Float64, Float64}
navidcy
approved these changes
Mar 6, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5375 +/- ##
==========================================
- Coverage 73.97% 73.97% -0.01%
==========================================
Files 418 418
Lines 25263 25263
==========================================
- Hits 18689 18688 -1
- Misses 6574 6575 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
CI passes; I'm merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a potential bug in
on_architecturewhereby low precisionStepRangeLenwould be promoted to Float32.@loisbaker you can incorporate this into your PR if you like.