Immersed boundary as a plain OffsetArray#5737
Merged
Merged
Conversation
navidcy
reviewed
Jun 28, 2026
navidcy
reviewed
Jun 28, 2026
navidcy
approved these changes
Jun 28, 2026
Member
|
@simone-silvestri, the PR might have triggered some scalar operations? Docs and GPU Unit tests are failing. |
…ananigans.jl into ss/grid-bottom-as-offsetarrays
navidcy
reviewed
Jun 29, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5737 +/- ##
==========================================
+ Coverage 73.96% 74.00% +0.03%
==========================================
Files 418 418
Lines 25279 25281 +2
==========================================
+ Hits 18698 18708 +10
+ Misses 6581 6573 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we actually do not need a
Field(the grid is the same grid the immersed boundary is attached to). So it's good to have just plainOffsetArrays. It also help with memory allocation issues and keeping the field descriptor of a model a bit more contained; eachFieldhas a gigantic field descriptor, and on an immersed boundary we now have in mainField(Grid(Field(Grid))which explodes the descriptor by a factor of 2