Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Disable system_tables_lazy_load by default #11029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexey-milovidov merged 5 commits into from
May 20, 2020
Merged

Disable system_tables_lazy_load by default #11029

alexey-milovidov merged 5 commits into from
May 20, 2020

Conversation

@azat
Copy link
Member

@azat azat commented May 19, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make system_tables_lazy_load false by default

Detailed description / Documentation draft:

  • make system_tables_lazy_load false by default
  • fix test, that existed by did not run and did not passed
  • add example into config.xml

@blinkov blinkov added the pr-build Pull request with build/testing/packaging improvement label May 19, 2020
@azat
Copy link
Member Author

azat commented May 19, 2020 •
edited
Loading

node3_1 | Indirect leak of 5904 byte(s) in 82 object(s) allocated from:
node1_1 | 10 0x1fc47388 (/usr/bin/clickhouse+0x1fc47388)

Is there any plans/work in progress to configure symbolizer?

Anyway looks like leak is here (if I not messed up anywhere)

addr2line -e ../clickhouse-common-static-dbg/usr/lib/debug/usr/bin/clickhouse -i 0x17c3ef8f
/build/obj-x86_64-linux-gnu/../src/Disks/S3/registerDiskS3.cpp:110

And indeed this looks like a leak (cc @Jokser )

@Jokser
Copy link
Contributor

Jokser commented May 19, 2020

Hi @azat . Thank you for reporting this. Could you please create an issue about this leak, I'll try to fix it in the nearest time.

@azat azat mentioned this pull request May 19, 2020
Merged
@azat
Copy link
Member Author

azat commented May 19, 2020 •
edited
Loading

Build/Testing/Packaging Improvement

Did not find the right tag, feel free to update it to the right one.

@azat
Copy link
Member Author

azat commented May 19, 2020

About test failures:

test_replicated_merge_tree_s3/test.py::test_insert_select_replicated | ERROR

2020.05.19 19:28:25.278207 [ 1 ] {} <Error> Application: Caught exception while loading metadata: Code: 499, e.displayText() = DB::Exception: The specified bucket does not exist, Stack trace (when copying this message, always include the lines below):

test_version_update_after_mutation/test.py::test_mutate_and_upgrade | FAILED
test_version_update_after_mutation/test.py::test_upgrade_while_mutation | FAILED
test_always_fetch_merged/test.py::test_replica_always_download

all above looks time related

@Jokser Jokser mentioned this pull request May 20, 2020
Merged
@alexey-milovidov alexey-milovidov self-assigned this May 20, 2020
@alexey-milovidov alexey-milovidov merged commit 07924f0 into ClickHouse:master May 20, 2020
@azat azat deleted the system_tables_lazy_load branch May 20, 2020 20:08
@Jokser Jokser mentioned this pull request May 22, 2020
Merged
This was referenced May 29, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azat @Jokser @alexey-milovidov @blinkov