Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix move_functions_out_of_any optimisation with lambda #12664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
4ertus2 merged 4 commits into from
Jul 23, 2020
Merged

Fix move_functions_out_of_any optimisation with lambda #12664

4ertus2 merged 4 commits into from
Jul 23, 2020

Conversation

@4ertus2
Copy link
Contributor

@4ertus2 4ertus2 commented Jul 22, 2020 •
edited by alexey-milovidov
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix optimization optimize_move_functions_out_of_any=1 in case of any(func(<lambda>)).

Closes #12621

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Jul 22, 2020
CurtizJ
CurtizJ reviewed Jul 22, 2020
View reviewed changes
@4ertus2
Copy link
Contributor Author

4ertus2 commented Jul 22, 2020

This query fails

WITH any(number * 1) AS x SELECT x FROM numbers(1);

@CurtizJ
Copy link
Member

CurtizJ commented Jul 22, 2020 •
edited
Loading

Seems that clone of ast is still needed. Previously there was the same problem.
#11529 (comment)

@4ertus2
Copy link
Contributor Author

4ertus2 commented Jul 23, 2020 •
edited
Loading

Seems that clone of ast is still needed.

I've made a solution without clone(). Clone after normalize() breaks indirect assumption that the aliases links to the same AST object. This assumtion should not be used later. But all our tests are for scenario where we do not break this assumption. So it's very easy to catch bugs here.

@CurtizJ CurtizJ self-requested a review July 23, 2020 14:54
@4ertus2 4ertus2 merged commit 2041d7d into ClickHouse:master Jul 23, 2020
This was referenced Jul 27, 2020
Merged
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Jul 28, 2020
Backport #12664 to 20.6: Fix move_functions_out_of_any optimisation w…
ce3b75b 
…ith lambda
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 28, 2020
Merged
robot-clickhouse pushed a commit that referenced this pull request Jul 28, 2020
Backport #12664 to 20.3: Fix move_functions_out_of_any optimisation w…
850f291 
…ith lambda
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 28, 2020
Closed
robot-clickhouse pushed a commit that referenced this pull request Jul 28, 2020
Backport #12664 to 20.5: Fix move_functions_out_of_any optimisation w…
39c6c9b 
…ith lambda
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 28, 2020
Merged
robot-clickhouse pushed a commit that referenced this pull request Jul 28, 2020
Backport #12664 to 20.4: Fix move_functions_out_of_any optimisation w…
37b50ef 
…ith lambda
@robot-clickhouse robot-clickhouse mentioned this pull request Jul 28, 2020
Closed
4ertus2 pushed a commit that referenced this pull request Jul 31, 2020
@robot-clickhouse
Backport #12664 to 20.6: Fix move_functions_out_of_any optimisation w…
157e293 
…ith lambda (#12994)
4ertus2 pushed a commit that referenced this pull request Aug 3, 2020
@robot-clickhouse
Backport #12664 to 20.5: Fix move_functions_out_of_any optimisation w…
82841a0 
…ith lambda (#12996)
@azat azat mentioned this pull request Aug 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CurtizJ CurtizJ CurtizJ approved these changes

Assignees

@CurtizJ CurtizJ

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DB::Exception: lambda argument declarations must be identifiers.

3 participants

@4ertus2 @CurtizJ @robot-clickhouse