Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use join() instead of detach() for threads #2 #14604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vitlibar merged 1 commit into from
Sep 11, 2020
Merged

Use join() instead of detach() for threads #2 #14604

vitlibar merged 1 commit into from
Sep 11, 2020

Conversation

@vitlibar
Copy link
Member

@vitlibar vitlibar commented Sep 9, 2020 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Not for changelog

This fixes thread leak in StorageLiveView (https://clickhouse-test-reports.s3.yandex.net/14404/7ca155c417a4ac64f448c390cc5f5462540b204f/stress_test_(thread)/stderr.log).

@vitlibar vitlibar added pr-bugfix Pull request with bugfix, not backported by default pr-not-for-changelog This PR should not be mentioned in the changelog labels Sep 9, 2020
@vitlibar vitlibar force-pushed the no-detach-threads-2 branch 2 times, most recently from b1b1c4c to 95a8cc6 Compare September 9, 2020 16:37
@vitlibar vitlibar force-pushed the no-detach-threads-2 branch from 95a8cc6 to 2a9ab48 Compare September 9, 2020 19:39
@vitlibar
Copy link
Member Author

vitlibar commented Sep 11, 2020 •
edited
Loading

The failed performance tests have nothing to do with StorageLiveView.

@vitlibar vitlibar merged commit 70b0fe8 into ClickHouse:master Sep 11, 2020
@vitlibar vitlibar deleted the no-detach-threads-2 branch September 11, 2020 23:07
This was referenced Sep 11, 2020
Merged
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Sep 12, 2020
Backport #14604 to 20.6: Use join() instead of detach() for threads #2
ecbe4a4
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 12, 2020
Closed
robot-clickhouse pushed a commit that referenced this pull request Sep 12, 2020
Backport #14604 to 20.9: Use join() instead of detach() for threads #2
1f4fb47
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 12, 2020
Closed
robot-clickhouse pushed a commit that referenced this pull request Sep 12, 2020
Backport #14604 to 20.8: Use join() instead of detach() for threads #2
181c6e6
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 12, 2020
Closed
robot-clickhouse pushed a commit that referenced this pull request Sep 12, 2020
Backport #14604 to 20.7: Use join() instead of detach() for threads #2
3aaf386
@robot-clickhouse robot-clickhouse mentioned this pull request Sep 12, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr-bugfix Pull request with bugfix, not backported by default pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@vitlibar