Revert "Revert "less sys calls #2: make vdso work again"" #28132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitaisreal
approved these changes
Aug 25, 2021
Member
Author
|
Everything is alright. |
Contributor
Member
Author
|
@filimonov That's for good. #27492 is performance improvement and bug introduce. Only bugfixes are backported after prestable branch is created. |
azat
reviewed
Jan 24, 2022
| if (!__environ) | ||
| { | ||
| // __environ is not initialized yet so we can't initialize __auxv right now. | ||
| // That's normally occurred only when getauxval() is called from some sanitizer's internal code. |
Member
There was a problem hiding this comment.
when getauxval() is called from some sanitizer's internal code
And this can be interpreted as "sanitizers may not work correctly", and this is exactly what will happen - #33957
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #27829
#27993