Remove filter column from HAVING when it is not needed. #29475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Avogar
approved these changes
Sep 29, 2021
This was referenced Sep 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 29, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 29, 2021
KochetovNicolai
added a commit
that referenced
this pull request
Oct 13, 2021
Backport #29475 to 21.8: Remove filter column from HAVING when it is not needed.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 13, 2021
Backport #29475 to 21.9: Remove filter column from HAVING when it is not needed.
KochetovNicolai
added a commit
that referenced
this pull request
Oct 13, 2021
Backport #29475 to 21.10: Remove filter column from HAVING when it is not needed.
taiyang-li
pushed a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Nov 5, 2021
…when it is not needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix possible
Block structure mismatchfor subqueries with pushed-downHAVINGpredicate. Fixes #29010Detailed description / Documentation draft:
In added test,
WHEREwas pushed down to subquery asHAVING, but was not removed itself. So that AST-optimized query has two similar filters, for having first, and then for where.HAVINGstep could not detect that filter column is not used anymore; it always kept it (replaced to constant).WHEREstep calculates the same condition with the same column name. It worked as long as result was constant. However, in case we split filter step, it was possible to get intermediate non-const column. Recently, it was prohibited to have const and non-const column in block. which caused exception.Fixed by allowing
HAVINGto drop unused filter.