Thanks to visit codestin.com
Credit goes to github.com

Skip to content

May be fix s3 tests #29762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kssenii merged 6 commits into from
Oct 6, 2021
Merged

May be fix s3 tests #29762

kssenii merged 6 commits into from
Oct 6, 2021

Conversation

@kssenii
Copy link
Member

@kssenii kssenii commented Oct 5, 2021 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

s3 tests with latest master pass locally, but also docker minio image was updated 2 days ago -- exactly when s3 tests started failing so may be this will fix it.
Error it failed with:
AWSErrorMarshaller: Encountered AWSError 'InternalError': We encountered an internal error, please try again

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 5, 2021
@alexey-milovidov
Copy link
Member

alexey-milovidov commented Oct 5, 2021

Please add a comment.

@kssenii
Copy link
Member Author

kssenii commented Oct 5, 2021

Flacky test in fast test

2021-10-05 11:55:21 01293_show_clusters:                                                    [ FAIL ] - result differs with reference: 
2021-10-05 11:55:21 --- /ClickHouse/tests/queries/0_stateless/01293_show_clusters.reference	2021-10-05 11:48:11.528451962 +0300
2021-10-05 11:55:21 +++ /ClickHouse/tests/queries/0_stateless/01293_show_clusters.stdout	2021-10-05 11:55:21.602094392 +0300
2021-10-05 11:55:21 @@ -1,2 +1,2 @@
2021-10-05 11:55:21  test_shard_localhost
2021-10-05 11:55:21 -test_shard_localhost	1	1	1	localhost	::1	9000	1	default		0	0	0
2021-10-05 11:55:21 +test_shard_localhost	1	1	1	localhost	::1	9000	1	default		0	1	41

@kssenii
Copy link
Member Author

kssenii commented Oct 5, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2021

Command update: success

Branch has been successfully updated

@alexey-milovidov alexey-milovidov self-assigned this Oct 5, 2021
@kssenii
Copy link
Member Author

kssenii commented Oct 6, 2021

some s3 tests failed for different reason

subprocess.TimeoutExpired: Command '['docker-compose', '--env-file', 
'/ClickHouse/tests/integration/test_s3_with_https/_instances_0/.env', '--project-name', 'roottests3withhttps', '--file', 
'/compose/docker_compose_minio.yml', 'up', '-d']' timed out after 300 seconds

But the same happened to rabbitmq

 subprocess.TimeoutExpired: Command '['docker-compose', '--env-file', '/ClickHouse/tests/integration/test_storage_rabbitmq/_instances_0/.env', '--project-name', 'rootteststoragerabbitmq', '--file', 
'/ClickHouse/tests/integration/test_storage_rabbitmq/_instances_0/instance/docker-compose.yml', '--file', 
'/compose/docker_compose_rabbitmq.yml', 'up', '-d', '--no-recreate']' timed out after 300 seconds

and mysql

subprocess.TimeoutExpired: Command '['docker-compose', '--env-file', '/ClickHouse/tests/integration/test_storage_mysql/_instances_0/.env', '--project-name', 'rootteststoragemysql', '--file', '/ClickHouse/tests/integration/test_storage_mysql/_instances_0/node1/docker-compose.yml', '--file', '/compose/docker_compose_mysql.yml', '--file', '/ClickHouse/tests/integration/test_storage_mysql/_instances_0/node2/docker-compose.yml', '--file', '/compose/docker_compose_mysql_cluster.yml', '--file', 
'/ClickHouse/tests/integration/test_storage_mysql/_instances_0/node3/docker-compose.yml', 'up', '-d', '--no-recreate']'
 timed out after 300 seconds

and postgresql

subprocess.TimeoutExpired: Command '['docker-compose', '--env-file', '/ClickHouse/tests/integration/test_storage_postgresql/_instances_0/.env', '--project-name', 'rootteststoragepostgresql', '--file', '/ClickHouse/tests/integration/test_storage_postgresql/_instances_0/node1/docker-compose.yml', '--file', '/compose/docker_compose_postgres.yml', '--file', 
'/ClickHouse/tests/integration/test_storage_postgresql/_instances_0/node2/docker-compose.yml', '--file', 
'/compose/docker_compose_postgres_cluster.yml', 'up', '-d', '--no-recreate']'
 timed out after 300 seconds

so it is a common issue happened yesterday..

btw I triggered flacky check for s3 tests and now thay successed though previously some of them were constantly failing in master Integration tests flaky check (asan) — No flaky tests: fail: 0, error: 0, passed: 13 so may be makes sence to merge this pr now.

@kssenii
Copy link
Member Author

kssenii commented Oct 6, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 6, 2021

Command update: success

Branch has been successfully updated

@kssenii
Copy link
Member Author

kssenii commented Oct 6, 2021 •
edited
Loading

I'll merge, previous issue is fixed.
Some s3 tests still failed but because of subprocess.TimeoutExpired: Command '['docker-compose'...

@kssenii kssenii merged commit e88005c into ClickHouse:master Oct 6, 2021
@kssenii kssenii mentioned this pull request Oct 7, 2021
Merged
@kssenii kssenii added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Oct 13, 2021
This was referenced Oct 13, 2021
Merged
Merged
Merged
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 13, 2021
Backport #29762 to 21.8: May be fix s3 tests
aec2447
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 13, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 13, 2021
Backport #29762 to 21.7: May be fix s3 tests
8789a61
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 13, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 13, 2021
Backport #29762 to 21.10: May be fix s3 tests
88646a9
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 13, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 13, 2021
Backport #29762 to 21.9: May be fix s3 tests
f93045f
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 13, 2021
Merged
kssenii added a commit that referenced this pull request Oct 14, 2021
@kssenii
Merge pull request #30131 from ClickHouse/backport/21.10/29762
25e8122 
Backport #29762 to 21.10: May be fix s3 tests
kssenii added a commit that referenced this pull request Oct 14, 2021
@kssenii
Merge pull request #30132 from ClickHouse/backport/21.9/29762
6c81d71 
Backport #29762 to 21.9: May be fix s3 tests
robot-clickhouse pushed a commit that referenced this pull request Oct 14, 2021
Backport #29762 to 21.3: May be fix s3 tests
9b5d2a6
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 14, 2021
Merged
kssenii added a commit that referenced this pull request Oct 14, 2021
@kssenii
Merge pull request #30129 from ClickHouse/backport/21.8/29762
63a3814 
Backport #29762 to 21.8: May be fix s3 tests
kssenii added a commit that referenced this pull request Oct 14, 2021
@kssenii
Merge pull request #30130 from ClickHouse/backport/21.7/29762
f90c7b3 
Backport #29762 to 21.7: May be fix s3 tests
kssenii added a commit that referenced this pull request Oct 15, 2021
@kssenii
Merge pull request #30154 from ClickHouse/backport/21.3/29762
fdca678 
Backport #29762 to 21.3: May be fix s3 tests
@Felixoid Felixoid added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kssenii @alexey-milovidov @Felixoid @robot-clickhouse