Fix shutdown of AccessControlManager #29951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on reloading after AccessControlManager has been destroyed.
vitlibar
commented
Oct 10, 2021
| /// Stop reloading of the main config. This must be done before `global_context->shutdown()` because | ||
| /// otherwise the reloading may pass a changed config to some destroyed parts of ContextSharedPart. | ||
| main_config_reloader.reset(); | ||
|
|
Member
Author
There was a problem hiding this comment.
I suppose the periodic config reloading should be stopped on shutdown earlier.
About shutting down of AccessControlManager see also #27804.
kitaisreal
approved these changes
Oct 10, 2021
This was referenced Oct 10, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 10, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 10, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 10, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 10, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 12, 2021
kitaisreal
added a commit
that referenced
this pull request
Oct 12, 2021
Backport #29951 to 21.8: Fix shutdown of AccessControlManager
kitaisreal
added a commit
that referenced
this pull request
Oct 12, 2021
Backport #29951 to 21.9: Fix shutdown of AccessControlManager
kitaisreal
added a commit
that referenced
this pull request
Oct 12, 2021
Backport #29951 to 21.3: Fix shutdown of AccessControlManager
alexey-milovidov
added a commit
that referenced
this pull request
Oct 16, 2021
Backport #29951 to 21.10: Fix shutdown of AccessControlManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category:
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix shutdown of
AccessControlManager. Now there can't be reloading of the configuration after AccessControlManager has been destroyed. This PR fixes the flaky test test_user_directories/test.py::test_relative_path