Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@azat
Copy link
Member

@azat azat commented Jan 30, 2022

Broken getauxval() breaks LSan (at least).

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Refs: #33957

Broken getauxval() breaks LSan (at least).

Signed-off-by: Azat Khuzhin <[email protected]>
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jan 30, 2022
@azat azat changed the title Disable glibc-compatiblity (due to broken getauxval()) for sanitizers Fix LSan by disabling glibc-compatiblity (due to broken getauxval()) Jan 30, 2022
@alexey-milovidov
Copy link
Member

No, we need sanitizer builds to be portable.
E.g. I build a binary on my machine and scp to server.

@azat
Copy link
Member Author

azat commented Jan 30, 2022

This was a temporary solution.
Since now LSan does not work at all, and to be worked non-portable LSan is better then portable not worked.
Besides it is likely to be portable, at least if glibc will not be too old on the destination server.

@alexey-milovidov
Copy link
Member

Ok.

@alexey-milovidov
Copy link
Member

Another solution is to implement your own dynamic loader.

@alexey-milovidov alexey-milovidov added the st-discussion When the implementation aspects are not clear or when the PR is on hold due to questions. label Jan 30, 2022
@azat azat marked this pull request as draft January 31, 2022 10:51
@alexey-milovidov alexey-milovidov removed their assignment Feb 1, 2022
@azat
Copy link
Member Author

azat commented Feb 9, 2022

AST fuzzer (ASan, actions) — Task failed: $?=137

SIGKILL (137-128=9)

Integration tests (asan, actions) [1/3] — fail: 3, passed: 642, flaky: 0

    E               Exception: Command ['docker', 'exec', '-u', '0', 'roottestbackupwithothergranularity_node1_1', 'bash', '-c', 'clickhouse server --config-file=/etc/clickhouse-server/config.xml --log-file=/var/log/clickhouse-server/clickhouse-server.log  --errorlog-file=/var/log/clickhouse-server/clickhouse-server.err.log --daemon'] return non-zero code 1: clickhouse: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.29' not found (required by clickhouse)

clickhouse-server:19.4.5.35 image uses ubuntu:18.04 and it has incompatible glibc, no good.

@azat azat closed this Feb 9, 2022
@azat azat deleted the sanitizers-disable-glibc-compat branch November 19, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog st-discussion When the implementation aspects are not clear or when the PR is on hold due to questions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants