Thanks to visit codestin.com
Credit goes to github.com

Skip to content

sequence state fix #48603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
KochetovNicolai merged 1 commit into from
May 2, 2023
Merged

sequence state fix #48603

KochetovNicolai merged 1 commit into from
May 2, 2023

Conversation

@ilejn
Copy link
Contributor

@ilejn ilejn commented Apr 10, 2023 •
edited by KochetovNicolai
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fixed that sequenceMatch() and sequenceCount() return wrong results when serialized state is used. Fixes #37296

@ilejn ilejn mentioned this pull request Apr 10, 2023
Closed
@ilejn ilejn force-pushed the sequence_state_fix branch from 77a63cf to 02d2f5c Compare April 10, 2023 15:28
@ilejn ilejn changed the title sequence state fix - works, tests added sequence state fix Apr 10, 2023
@ilejn
Copy link
Contributor Author

ilejn commented Apr 11, 2023

Test failure is unlikely related.

Enmk
Enmk approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilejn ilejn marked this pull request as ready for review April 24, 2023 15:30
@ilejn
Copy link
Contributor Author

ilejn commented Apr 24, 2023

Hello @KochetovNicolai , could you have a look, please?
This PR is basically a confirmation that your assumption #37296 (comment) is perfectly correct.

@KochetovNicolai KochetovNicolai self-assigned this May 2, 2023
@KochetovNicolai KochetovNicolai merged commit 6beff3b into ClickHouse:master May 2, 2023
@ilejn
Copy link
Contributor Author

ilejn commented May 3, 2023

Hello Nikolai, thanks for the merge.
I've received a bunch of notifications about PR test failures, e.g.

[ClickHouse/ClickHouse] PR run cancelled: PullRequestCI, Attempt #8 - sequence state fix (02d2f5c)

Does it mean that something related to the PR went wrong, or it is kind of normal?

This was referenced Sep 25, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

+1 more reviewer

@Enmk Enmk Enmk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@KochetovNicolai KochetovNicolai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sequenceMatch() and sequenceCount() return wrong results when run over a distributed table

3 participants

@ilejn @Enmk @KochetovNicolai