Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better tests / CI #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 18, 2022
Merged

Better tests / CI #136

merged 7 commits into from
Jan 18, 2022

Conversation

filimonov
Copy link
Contributor

@filimonov filimonov commented Jan 10, 2022 •
edited
Loading

preparations for #131

  • for macOS I've added tls offoader proxy, mimicking local clickhouse by tunneling the queries to a cloud instance of clickhouse
  • connection setting used in tests now configurable via env variables
  • fixed a couple of minor issues in tests, and some platform / compiler specific compilation issues
  • changed github actions from workflow to matrix (easier to modify, no hidden dependency from the master branch)
  • switch to temporary tables to isolate concurrent test, and simplify access management

@filimonov filimonov mentioned this pull request Jan 10, 2022
Merged
filimonov
filimonov commented Jan 10, 2022
View reviewed changes
.github/workflows/linux.yml
extra_cmake_flags: -DWITH_OPENSSL=ON

- build: gcc-9-ssl
INSTALL: gcc-9 g++-9
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups, it look like i didn't intall libssl-dev in every scenario, but somehow it works...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be already installed, but anyway let's make it explicit dependency

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your option much more 👍 Wasn't aware that you can make a cartesian product of matrixes this way

filimonov
filimonov commented Jan 11, 2022
View reviewed changes
Enmk
Enmk suggested changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor updates required, mostly comments, please see question inline.

tests/simple/CMakeLists.txt
@@ -6,3 +6,6 @@ TARGET_LINK_LIBRARIES (simple-test
clickhouse-cpp-lib
)

IF (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
set (CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} --rtlib=compiler-rt")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment that explains why this is required.

.github/workflows/linux.yml
extra_cmake_flags: -DWITH_OPENSSL=ON

- build: gcc-9-ssl
INSTALL: gcc-9 g++-9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be already installed, but anyway let's make it explicit dependency

filimonov
filimonov commented Jan 18, 2022
View reviewed changes
@Enmk Enmk merged commit b36c87f into master Jan 18, 2022
@Enmk Enmk deleted the better_tests branch February 1, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Enmk Enmk Enmk requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filimonov @Enmk