Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Minor fixes #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Minor fixes #227

wants to merge 1 commit into from

Conversation

Enmk
Copy link
Contributor

@Enmk Enmk commented Oct 17, 2022

  • attempt to fix 'unresolved external symbol "const clickhouse::ColumnFixedString::`vftable'"' @ string.h/.cpp
  • minor test improvement to verify Swap() correctness @ ut/Column_ut.cpp
  • exception if SSL wouldn't be configured by configureSSL @ sslsocket.cpp
  • removed unused QuerySettings @ query.h

@Enmk
Minor fixes
98c271c 
- attempt to fix 'unresolved external symbol "const clickhouse::ColumnFixedString::`vftable'"' @ string.h/.cpp
- minor test improvement to verify Swap() correctness @ ut/Column_ut.cpp
- exception if SSL wouldn't be configured by configureSSL @ sslsocket.cpp
- removed unused QuerySettings @ query.h
@Enmk Enmk mentioned this pull request Oct 17, 2022
Merged
@1261385937
Copy link
Contributor

Still has unresolved external symbol

@1261385937
Copy link
Contributor 

1>client_ut.obj : error LNK2001: unresolved external symbol "public: static class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const clickhouse::Query::default_query_id" (?default_query_id@Query@clickhouse@@2V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@B)
1>performance_tests.obj : error LNK2001: unresolved external symbol "public: static class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const clickhouse::Query::default_query_id" (?default_query_id@Query@clickhouse@@2V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@B)
1>roundtrip_column.obj : error LNK2001: unresolved external symbol "public: static class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const clickhouse::Query::default_query_id" (?default_query_id@Query@clickhouse@@2V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@B)
1>columns_ut.obj : error LNK2019: unresolved external symbol "const clickhouse::ColumnFixedString::`vftable'" (??_7ColumnFixedString@clickhouse@@6B@)，function "public: __cdecl clickhouse::ColumnFixedString::ColumnFixedString<class std::vector<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::allocator<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > > >(unsigned __int64,class std::vector<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >,class std::allocator<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > > > const &)" (??$?0V?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@@ColumnFixedString@clickhouse@@QEAA@_KAEBV?$vector@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V?$allocator@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@2@@std@@@Z) quote the symbol
1>D:\contrib\clickhouse-cpp-dll\clickhouse-cpp\sln\ut\Debug\clickhouse-cpp-ut.exe : fatal error LNK1120: two unresolved external symbol

@1261385937
Copy link
Contributor

@Enmk same time online. zzzz

@Enmk
Copy link
Contributor Author

Enmk commented Oct 17, 2022

@1261385937, could you please share the way you build it? I'm thinking about adding another CI/CD workflow variant to speed discovering/fixing such things up.

@1261385937
Copy link
Contributor

1261385937 commented Oct 17, 2022 •
edited
Loading

@1261385937, could you please share the way you build it? I'm thinking about adding another CI/CD workflow variant to speed discovering/fixing such things up.

clickhouse/CMakeLists.txt, add below line:

SET (CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS TRUE)

ut/CMakeLists.txt, change static to share:

TARGET_LINK_LIBRARIES (clickhouse-cpp-ut
    clickhouse-cpp-lib
    gtest-lib
)

At last, i use visual studio build the local branch

@Enmk Enmk closed this Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Enmk @1261385937