Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix abnormal column names in gcc7.3.1 #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Conversation

alenstarx
Copy link
Contributor

Fix abnormal column names in gcc7.3.1

example: "select 123,231,113"

on gcc7.3.1 output:
name:113, type:UInt8
name:113, type:UInt8
name:113, type:UInt8

on gcc9.3.1 output:
name:123, type:UInt8
name:231, type:UInt8
name:113, type:UInt8

Fix abnormal column names in gcc7.3.1
@CLAassistant
Copy link

CLAassistant commented Jul 18, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add a test

@alenstarx
Copy link
Contributor Author

Looks good, but please add a test

OK, Test has been added.

…ove test suite instantiation right to the definition of the test itself
Copy link
Contributor

@Enmk Enmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit f8c43da into ClickHouse:master Jul 31, 2023
Enmk added a commit that referenced this pull request Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants