Implement 2 missing Excel functions and adapt 2 existing functions #2199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OKUP requires sorted values and test data didn't have that.
….g. argument "TRUE" doesn't work while "0.001" does).
Neither spec, not Excel says that it returns #NUM! on zero periods.
When rate is -1, there can be NaN result due to division by zero. Excel treats anything below -1 as #NUM! error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch started with an investigation into some bugs I encountered where under certain circumstances, the
PMTandHLOOKUPfunctions could get into an infinite calculation loop if they referenced cells that hadn't been calculated yet.Changing them over to the new
Adaptfunction structure solved that issue for me as that auto handles missing values in the new calc-chain system. AdaptingPMTwas very straightforward, and forHLOOKUPI basically just copied the implementation forVLOOKUP, which had already been changed toAdapt, and switched row/column lookups around.In the same spreadsheet I was also seeing errors because the
IPMTfunction was being used in the spreadsheet but hadn't been implemented in ClosedXML, so while I was in there I also implementedIPMTandFV(which theIPMTcalculation depends on).