Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update OpenXML SDK to 3.0. #2248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2024
Merged

Update OpenXML SDK to 3.0. #2248

merged 1 commit into from
Jan 28, 2024

Conversation

jahav
Copy link
Member

@jahav jahav commented Jan 5, 2024

Quick update of source code to reflect changes in OpenXML SDK 3.0. It requires net462 and System.IO.Packaging 8.0.0.

One test fails (SavingTests.SavesAsProperSpreadsheetDocumentType) which was caused by dotnet/Open-XML-SDK#1615. That should be fixed in 3.1 that should be done soon, only one issue remains for 3.1 milestone.

@jahav jahav mentioned this pull request Jan 5, 2024
Closed
@hyzx86 hyzx86 mentioned this pull request Jan 6, 2024
Closed
@twsouthwick
Copy link
Contributor

twsouthwick commented Jan 9, 2024 •
edited
Loading

I should have a v3.0.1 with the fix available in a couple of days (hopefully tomorrow, but to set expectations a few days).

Let me know if you find any other issues with v3 as you roll it out - I'll try to address any regressions :)

@twsouthwick
Copy link
Contributor

v3.0.1 is available on nuget with the requested fix - please give it a try

@twsouthwick
Copy link
Contributor

It requires net462 and System.IO.Packaging 8.0.0.

The supported TFMs are still the same. We support .NET Framework 3.5+, .NET Standard 2.0, .NET Core/5+

@twsouthwick
Copy link
Contributor

twsouthwick commented Jan 9, 2024 •
edited
Loading

You may be seeing a change in the support of System.IO.Packaging; however, on framework it never actually did anything and type forwarded to WindowsBase.dll

@jahav
Copy link
Member Author

jahav commented Jan 11, 2024

@twsouthwick Thanks! Great work.

Test passes. I am looking forward to leverage the new IPackage and I think I there were few malformed relationship URIs bugs over the years, so that will be really nice to check out too.

@jahav jahav added this to the v0.104 milestone Jan 11, 2024
nefarius added a commit to nefarius/Nefarius.CsvHelper.Excel that referenced this pull request Jan 22, 2024
@nefarius
Things are still broken :D ClosedXML/ClosedXML#2248
e83d8ec
nefarius added a commit to nefarius/Nefarius.CsvHelper.Excel that referenced this pull request Jan 22, 2024
@nefarius
Revert "Things are still broken :D ClosedXML/ClosedXML#2248"
4d1f730 
This reverts commit e83d8ec.
@nefarius nefarius mentioned this pull request Jan 22, 2024
Open
@jahav jahav marked this pull request as ready for review January 28, 2024 15:55
@jahav jahav changed the title Draft: Update OpenXML SDK to 3.0. Update OpenXML SDK to 3.0. Jan 28, 2024
@jahav jahav merged commit cbe81fa into develop Jan 28, 2024
@jahav jahav deleted the openxmk-sdk-3 branch January 28, 2024 16:11
@hyzx86 hyzx86 mentioned this pull request Jan 29, 2024
Closed
8 tasks
@jahav jahav mentioned this pull request Mar 20, 2024
Closed
5 tasks
@marcominerva marcominerva mentioned this pull request Apr 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.104
Development

Successfully merging this pull request may close these issues.
2 participants
@jahav @twsouthwick