Write pivot table row/column axes, filter fields and data fields #2290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old code has a difficulty reading style because it needs to translate from file structures to data structures. The new structures are more in-line with a file, leading to easier loading and saving. This adds ability to read and write formats, so it can work with more pivot tables in various files. The code is in Writer2 that is not used in rest of codebase yet. We have no special object for dxf, so use XLStyle. That makes me unhappy, but a lot of things make me unhappy.
The original code - didn't correctly loaded items because it didn't consider whole row/col items. - writer didn't take into account that non-data item types (e.g. sum) always have at least one x item.
Originally, XmlWriter added the namespace declaration at the end of pivotTableDefinition opening tag, add it at the beginning, so comparison is easier.
Pivot table is completely under our control and there is no use at this time of revision or markup compatibility namespace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve pivot table Writer2 by adding code to write row/column axes, filter fields, data fields and filters/styles. It now can load and write pivot table with style and not crash (at least sometimes). This is further improvement, so we can just load and write PT without crashing/mangling it.
Pivot table styles use differential formatting, but because ClosedXML doesn't yet have support for it, just use XLStyle object for now, Styles will need a complete rework to support named styles and differential formatting, but that is work for another release in the future.
This is still in Writer2, i.e. unused code paths.