Fix an edge case when ranges got unmerged when the adjacent range of the same size got deleted #2358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @masterworgen discovered by using ClosedXML.Report, there is an edge case causing a range to be unmerged.
Reproduction:
Original file:
Expected result:
Actual result:
Template.xlsx
This happens if there is a merged range of exactly same size just below a range to be deleted (with
ShiftCellsUps
mode), or to the right of it (whenShiftCellsLeft
mode is used).The reason of such a behavior is the usage of ranges repository: when all affected ranges are being adjusted in
NotifyRangeShiftedRows
/NotifyRangeShiftedColumns
, first we update the merged range and it becomes the exact clone of the range to be deleted (therefore, they both are "optimized" by the repository to reference the same instance); and then the deleted range gets destoyed, together with the merged one.In the PR, I am handling this edge case: if any range becomes identical to the original one then we don't have to process this range outside the loop.