Update rich text when text of a run changes #2516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have mutable API for rich text string, but the implementation must be immutable. Immutability is required by shared string table, that stores whole rich text as one entry in a dictionary and it's not acceptable to change the stored text. To solve this problem, rich text is mostly a facade that changes immutable text when user calls a mutating method. Property setter IXLRichText.Text didn't call "update-immutable-rich-text" method and thus text wasn't changed. Fixes #2430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a property setter
IXLRichString.Text(basically a representation of a rich text run) was called, the enveloping rich textIXLRichTextdidn't change.We have mutable API for rich texts, but the implementation must be immutable. Immutability is required by shared string table that stores whole rich text as one entry in a dictionary. Key in a dictionary must be immutable (keep same hash keys and so on).
To solve this problem,
IXLRichTextis mostly a facade that changes immutable text when user calls a mutating method.Property setter IXLRichText.Text didn't call "update-immutable-rich-text" method and thus text wasn't changed.
My confidence in
RichTextandXLComment(aka. mutable-API-changing-immutable-XLImmutableRichTextadapters) is low and they should be rethought and rewritten andXLFormattedTextprobably deleted. Let's add it to the never-ending pile "should be done".Fixes #2430