Reimplement 10 simple mathtrig funcs #2524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5b282bf to
2bdf801
Compare
2bdf801 to
ae1b144
Compare
ae1b144 to
8a8bcd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement/convert 11 MathTrig functions (
SIGN,SECH,SEC,COT,COTH,CSC,CSCH,ACOT,ACOTH,COMBINA) from legacyExpressionbased signature to standardAnyValueone.Should mostly fix bugs with adapters and coercion. Also, the there was an excessive check on
COMBINA(COMBINA(10, 15)- second is greater than first) that was removed, because Excel accepts such arguments.