Update ClosedParser to 2.0 (bang reference) #2596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2.0 version has two new methods in IAstFactory. BangReference and BangName. BangName is not actually parsed yet, but will be.
6 tasks
|
@jahav I have been using ClosedXML 0.105.0-rc, which i downloaded from https://ci.appveyor.com/project/ClosedXML/ClosedXML/branch/develop/artifacts which needs ClosedXML.Parser2.0.0-preview1, from where i can get that, i could not find on nuget. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser version 2.0 has two new methods in the
IAstFactoryinterface for bang references (used only in defined names). Adding methods to interface is a breaking change, so major version was increased to 2.Bang reference (e.g.
!$B$7:$D$8) areNotSupportedNodefor now.There is also a method for bang name (
!Data), but it's not yet parseable, but will be.ClosedXML.Parser 2.0.0-preview1 package is unlisted on nuget.org.