Depend only on XMLKit: drop SwiftText and the DocC plugin#1322
Merged
Conversation
DTCoreText only ever imported the HTMLParser module, which now lives in its own package (Cocoanetics/XMLKit, extracted from SwiftText with history). Depending on the HTMLParser product directly drops SwiftText, swift-markdown and swift-cmark from the graph, and no traits are needed anymore. swift-docc-plugin is gone too: Swift Package Index injects the plugin automatically when building hosted documentation (.spi.yml), Xcode builds the DocC catalog natively, and CI never generates docs. With it go SymbolKit and swift-argument-parser. Resolved dependencies shrink from five packages to one: xmlkit 1.0.1. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DTCoreText's resolved dependency graph shrinks from five packages to one:
xmlkit 1.0.1.HTMLParsermodule. That parser now lives in its own package — Cocoanetics/XMLKit, extracted from SwiftText with full git history and adopted back by SwiftText in SwiftText#23. Depending on theHTMLParserproduct directly (semver-pinnedfrom: 1.0.1instead ofbranch: main) drops SwiftText, swift-markdown and swift-cmark from the graph; theHTMLtrait setting goes with it..spi.ymlkeeps working), Xcode builds theDTCoreText.docccatalog natively, and CI never generates documentation. This also removes SymbolKit and swift-argument-parser.Verification
import HTMLParserresolves to the identical module; onlyPackage.swiftandPackage.resolvedmove.🤖 Generated with Claude Code