Conversation
Detect the operating system via `linux-gnu` and dynamically set the
`SED_INPLACE` variable to handle differences in `sed -i` syntax between
macOS (requires `-i ''`) and Linux (requires `-i`).
Previously, the script hardcoded `sed -i ''` which only worked on macOS,
causing failures when run on Linux. This change replaces all four
occurrences with the platform-adaptive `sed "${SED_INPLACE[@]}"` pattern,
making the script compatible with both macOS and Linux environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect the operating system via
linux-gnuand dynamically set theSED_INPLACEvariable to handle differences insed -isyntax between macOS (requires-i '') and Linux (requires-i).Previously, the script hardcoded
sed -i ''which only worked on macOS, causing failures when run on Linux. This change replaces all four occurrences with the platform-adaptivesed "${SED_INPLACE[@]}"pattern, making the script compatible with both macOS and Linux environments.