Update xmlhttprequest timeout and percentage complete#104
Merged
rotosonic merged 10 commits intoComcast:masterfrom Aug 16, 2017
Merged
Update xmlhttprequest timeout and percentage complete#104rotosonic merged 10 commits intoComcast:masterfrom
rotosonic merged 10 commits intoComcast:masterfrom
Conversation
|
|
Collaborator
|
forgot to make changes in downloadApp.js and uploadApp.js |
| } | ||
| console.dir(result); | ||
| if (this._running) { | ||
| if ((Date.now() - this._beginTime) > this.testLength) { |
Collaborator
There was a problem hiding this comment.
we might need a 'else' case here to send the error back if it is during the 12 sec
Collaborator
Author
There was a problem hiding this comment.
abort all requests and show opps
| clearInterval(this.interval); | ||
| this._running = false; | ||
| } | ||
| console.dir(result); |
Collaborator
There was a problem hiding this comment.
a quick question: will it be any help to us having the console here.. without have it in the splunk?
Collaborator
Author
There was a problem hiding this comment.
yes for browser review and will pass to splunk dependent on test time
rotosonic
commented
Aug 16, 2017
| this._running = false; | ||
| if ((Date.now() - this._beginTime) > this.testLength) { | ||
| this.endTest(); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
update similar to downloads
|
+1 once you address comment we discuss to add else block with abort all and Oops message |
Collaborator
|
+1 provisional, once you address comments |
7efc7b1 to
bb3a5b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Edge 15 is periodically throwing error at the end of testing due to timing issue and need to report percentage complete to client
How: Update timing logic to remove error and return percentage complete
Test: check locally and run in edge 15 and verify test completes with no error