Make the CommandAPI complain less about command registered in the plugin.yml #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ugin.yml if the plugin.yml belongs to the plugin calling the CommandAPI
…ependent of verbose outputs
JorelAli
reviewed
Jan 1, 2023
...ndapi-bukkit/commandapi-bukkit-core/src/main/java/dev/jorel/commandapi/CommandAPIBukkit.java
Outdated
Show resolved
Hide resolved
DerEchtePilz
added a commit
that referenced
this pull request
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title is not great, I know and it can be misunderstood!
I once experienced this while using the CommandAPI:
In my plugin, I register a command permission. LuckPerms also registers a command permission.
The CommandAPI does this:
[01:15:12 WARN]: [CommandAPI] Plugin command /permission is registered by Bukkit (LuckPerms). Did you forget to remove this from your plugin.yml file?Here is what the PR does:
This PR makes it so that the CommandAPI doesn't complain about plugin commands registered in a
plugin.ymlif theplugin.ymldoesn't belong to the plugin calling the CommandAPI.