Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add support for a NamespacedKey variant for the PotionEffectArgument #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2024
Merged

Add support for a NamespacedKey variant for the PotionEffectArgument #541

merged 4 commits into from
Apr 25, 2024

Conversation

DerEchtePilz
Copy link
Member

No description provided.

@DerEchtePilz DerEchtePilz force-pushed the dev/namespaced-key-potion-effect-argument branch 2 times, most recently from 79ca29d to 09e11d9 Compare April 11, 2024 09:54
@DerEchtePilz DerEchtePilz force-pushed the dev/namespaced-key-potion-effect-argument branch from eef2246 to c9ffb55 Compare April 23, 2024 19:02
JorelAli
JorelAli reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@JorelAli JorelAli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests?

We have tests for other NamespacedKey arguments, such as SoundArgument.NamespacedKey and BiomeArgument.NamespacedKey

@DerEchtePilz DerEchtePilz force-pushed the dev/namespaced-key-potion-effect-argument branch 4 times, most recently from fff2cf0 to d80dab0 Compare April 24, 2024 15:25
@DerEchtePilz DerEchtePilz force-pushed the dev/namespaced-key-potion-effect-argument branch from d80dab0 to 82bcce5 Compare April 25, 2024 11:23
@DerEchtePilz DerEchtePilz merged commit eb62e54 into dev/dev Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorelAli JorelAli JorelAli left review comments

@willkroboth willkroboth Awaiting requested review from willkroboth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerEchtePilz @JorelAli