Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

Sergio0694
Copy link
Member

Related to microsoft/CsWinRT#1861

This PR adds two new analyzers for WinRT scenarios:

  • Warn on [ObservableProperty] on fields in WinRT AOT scenarios
  • Warn on [RelayCommand] on methods within types using [GeneratedBindableCustomProperty]

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

@Sergio0694 Sergio0694 added mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit analyzer 👓 A new analyzer being implemented or updated labels Nov 7, 2024
@Sergio0694 Sergio0694 force-pushed the dev/winrt-analyzers branch 2 times, most recently from 9789f34 to 1202ab5 Compare November 7, 2024 08:44
@Sergio0694 Sergio0694 force-pushed the dev/winrt-analyzers branch 2 times, most recently from 3bf3185 to f74269b Compare November 8, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer 👓 A new analyzer being implemented or updated mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant