Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Slmicro5 disable ipv6 rules #13524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2025
Merged

Slmicro5 disable ipv6 rules #13524

merged 5 commits into from
Jun 26, 2025

Conversation

teacup-on-rockingchair
Copy link
Contributor

Description:

  • Patches related to disable ipv6 rules for SL Mirco 5 platforms

Rationale:

  • Make sure sysctl ipv6 is applicable on platform basis
  • Make sure that slmicro5 is considered suse family so grub macros work
  • Add slmicro5 support for grub configuration
  • Make sure right file is used for grub config for sle platforms

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label May 31, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 31, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@teacup-on-rockingchair teacup-on-rockingchair marked this pull request as ready for review June 21, 2025 07:57
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Jun 21, 2025
@teacup-on-rockingchair teacup-on-rockingchair added this to the 0.1.78 milestone Jun 21, 2025
@teacup-on-rockingchair teacup-on-rockingchair added SLES SUSE Linux Enterprise Server product related. ok-to-test Used by openshift-ci bot. Update Rule Issues or pull requests related to Rules updates. Update Template Issues or pull requests related to Templates updates. labels Jun 21, 2025
@jan-cerny jan-cerny self-assigned this Jun 23, 2025
jan-cerny
jan-cerny reviewed Jun 23, 2025
View reviewed changes
...de/system/network/network-ipv6/disabling_ipv6/sysctl_net_ipv6_conf_all_disable_ipv6/rule.yml
@@ -49,7 +49,11 @@ ocil: |-
files in <tt>/etc/sysctl.d</tt>:
<pre>$ grep -r ipv6 /etc/sysctl.d</pre>

{{% if product in ["sle12", "sle15", "slmicro5"] %}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to list "slmicro5" in this list when the rule isn't part of slmicro5 product content?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are completely right forgot to add the change in the control file on that one also 🙇

@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5_disable_ipv6_rules branch from dc03e64 to 9fc35c8 Compare June 25, 2025 05:50
jan-cerny
jan-cerny reviewed Jun 25, 2025
View reviewed changes
...ystem/network/network-ipv6/disabling_ipv6/sysctl_net_ipv6_conf_default_disable_ipv6/rule.yml
@@ -44,7 +44,11 @@ ocil: |-
files in <tt>/etc/sysctl.d</tt>:
<pre>$ grep -r ipv6 /etc/sysctl.d</pre>

{{% if product in ["sle12", "sle15", "slmicro5"] %}}
platform: ipv6[enabled]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teacup-on-rockingchair Sorry for noticing it late, but I suspect this rule suffers from the same problem, I can't find it in the built slmicro5 data stream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that totally makes sense I changed it not to include slmicro5

@teacup-on-rockingchair teacup-on-rockingchair force-pushed the slmicro5_disable_ipv6_rules branch from 9fc35c8 to eeb80c1 Compare June 25, 2025 08:34
@qlty-cloud-legacy Qlty Cloud (Legacy)
Copy link

Code Climate has analyzed commit eeb80c1 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny merged commit 1965c7e into ComplianceAsCode:master Jun 26, 2025
131 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-cerny jan-cerny jan-cerny approved these changes

Assignees

@jan-cerny jan-cerny

Labels
ok-to-test Used by openshift-ci bot. SLES SUSE Linux Enterprise Server product related. Update Rule Issues or pull requests related to Rules updates. Update Template Issues or pull requests related to Templates updates.
Projects
None yet
Milestone
0.1.78
Development

Successfully merging this pull request may close these issues.
2 participants
@teacup-on-rockingchair @jan-cerny