Fix GRUB 2 UEFI selections in RHEL 9 ANSSI profiles #13598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GRUB 2 unified UEFI and non-UEFI configuration path to /boot/grub2. There are 2 groups of almost identical rules which differ only by configuration pathL linux_os/guide/system/bootloader-grub2/uefi and linux_os/guide/system/bootloader-grub2/non-uefi. After the unification, only rules from the second group should be used. The unselection of the rules from the other group was completed in past. However, we discovered one omission in RHEL 9 ANSSI profiles. Some rule were unselected in ANSSI enhanced profile, but they weren't unselected in ANSSI high profile. The ANSSI high profile is supposed to inherit from ANSSI enhanced profile. These rules come from R29 which is part of enhanced level. Moreover, the rule grub2_uefi_password is also a logical duplicate of grub2_password and should be removed on RHEL 9.
|
Code Climate has analyzed commit 933db42 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 61.9% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GRUB 2 unified UEFI and non-UEFI configuration path to /boot/grub2. There are 2 groups of almost identical rules which differ only by configuration pathL
linux_os/guide/system/bootloader-grub2/uefi and
linux_os/guide/system/bootloader-grub2/non-uefi.
After the unification, only rules from the second group should be used.
The unselection of the rules from the other group was completed in past. However, we discovered one omission in RHEL 9 ANSSI profiles. Some rule were unselected in ANSSI enhanced profile, but they weren't unselected in ANSSI high profile. The ANSSI high profile is supposed to inherit from ANSSI enhanced profile. These rules come from R29 which is part of enhanced level.
Moreover, the rule grub2_uefi_password is also a logical duplicate of grub2_password and should be removed on RHEL 9.