[WIP] Fix issue with Copilot action - #2
Merged
Conversation
Agent-Logs-Url: https://github.com/batt1984rodrigo-del/docs/sessions/10469b02-9d34-42e2-8378-bc1a00fe01ee Co-authored-by: batt1984rodrigo-del <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Pull request overview
This PR updates an Azure container deployment GitHub Actions workflow to avoid failing automatic runs by switching its trigger from push to manual workflow_dispatch (the workflow’s Docker build depends on a private GHCR base image and a placeholder Azure Web App configuration). Review provided by GitHub Copilot.
Changes:
- Removed the
pushtrigger onmainand changed the workflow to run only viaworkflow_dispatch. - Added inline rationale in the workflow explaining why automatic runs fail in forks/unconfigured environments.
Comment on lines
+34
to
+38
| # ghcr.io/github/gh-base-image/gh-base-noble base image referenced in the | ||
| # Dockerfile (which is intended for GitHub's internal Moda production | ||
| # deployment) and on an Azure Web App configured with the placeholder | ||
| # AZURE_WEBAPP_NAME below. Automatic runs on push fail with 403 Forbidden | ||
| # when pulling the base image in forks or unconfigured environments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.