fix(react): prevent Enter from sending message during IME composition#3322
Open
zhangxinping666 wants to merge 1 commit intoCopilotKit:mainfrom
Open
fix(react): prevent Enter from sending message during IME composition#3322zhangxinping666 wants to merge 1 commit intoCopilotKit:mainfrom
zhangxinping666 wants to merge 1 commit intoCopilotKit:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 466f94d The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
@zhangxinping666 is attempting to deploy a commit to the CopilotKit Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3318
CopilotChatInput (v2) does not handle IME composition events. When typing Chinese/Japanese/Korean characters, pressing Enter to commit the composition sends the message prematurely instead of finalizing the characters.
Changes
isComposingRefto track IME composition stateonCompositionStart/onCompositionEndhandlers on the textareasetTimeout(0)e.nativeEvent.isComposingas defense-in-depth browser fallbackPrior Art
packages/v1/react-ui/src/components/chat/Input.tsx)examples/v2/angular/demo/.../custom-chat-input.component.ts)Test Plan