Fix isModalDefaultOpen always true in useCopilotChatConfiguration#3340
Open
Fix isModalDefaultOpen always true in useCopilotChatConfiguration#3340
isModalDefaultOpen always true in useCopilotChatConfiguration#3340Conversation
When CopilotChatConfigurationProvider is nested, the inner provider's isModalDefaultOpen was ignored because the useState initializer preferred the parent's isModalOpen value via ??. Since shouldCreateModalState already gates when internalModalOpen is used, the initializer should always use the provider's own resolvedDefaultOpen. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
🦋 Changeset detectedLatest commit: ec0382f The changes in this PR will be included in the next version bump. This PR includes changesets to release 23 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📣 Social Copy GeneratorGenerate social media copies (Twitter/X, LinkedIn, Blog Post) for this PR using Claude.
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run-many -t build --projects=packages/** |
✅ Succeeded | 1s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-03-03 00:35:56 UTC
@copilotkit/a2ui-renderer
@copilotkit/react-core
@copilotkit/react-textarea
@copilotkit/react-ui
@copilotkit/runtime
@copilotkit/runtime-client-gql
@copilotkit/sdk-js
@copilotkit/shared
@copilotkitnext/agent
@copilotkitnext/angular
@copilotkitnext/core
@copilotkitnext/react
@copilotkitnext/runtime
@copilotkitnext/shared
@copilotkitnext/sqlite-runner
@copilotkit/voice
@copilotkitnext/web-inspector
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CopilotChatConfigurationProviderignoring innerisModalDefaultOpenwhen parent already has modal stateuseStateinitializer usedparentConfig?.isModalOpen ?? resolvedDefaultOpen, so the parent's value always won via??— changed to useresolvedDefaultOpendirectly sinceshouldCreateModalStatealready handles parent passthroughRelated PRs and Issues