Consolidate GetReferencedType method #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced ICompiledTypeAccessor as a way to get at a compiled type given a virtual path earlier this week. In order to consolidate the GetReferencedType code to utilize this fully, some changes to MasterPage were required. All of these revert the code back to what the original system did; that is, these changes had been put in as we bootstrapped the system and now we can use the original patterns.
birojnayak
reviewed
Mar 9, 2024
| * Build the strongly typed new property | ||
| */ | ||
| // e.g. public new {propertyType} Master { get { return ({propertyType})base.Master; } } | ||
|
|
birojnayak
approved these changes
Mar 9, 2024
Collaborator
birojnayak
left a comment
There was a problem hiding this comment.
This is as original as referencesource except build is replaced with new API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced ICompiledTypeAccessor as a way to get at a compiled type given a virtual path earlier this week. In order to consolidate the GetReferencedType code to utilize this fully, some changes to MasterPage were required. All of these revert the code back to what the original system did; that is, these changes had been put in as we bootstrapped the system and now we can use the original patterns.
Fixes #232