Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@twsouthwick
Copy link
Collaborator

No description provided.

@twsouthwick twsouthwick requested a review from birojnayak March 11, 2024 19:36
@github-actions
Copy link

github-actions bot commented Mar 11, 2024

Test Results

 4 files  ±0   4 suites  ±0   19s ⏱️ -7s
18 tests ±0  16 ✅ ±0  2 💤 ±0  0 ❌ ±0 
36 runs  ±0  32 ✅ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 17ce0d7. ± Comparison against base commit cbda2fc.

♻️ This comment has been updated with latest results.

@Code-DJ
Copy link
Contributor

Code-DJ commented Mar 11, 2024

@twsouthwick in the readme, is AddCompiledPages always needed or is it either or?

.AddDynamicPages() // Remove if you don't have dynamic pages
.AddCompiledPages();

@twsouthwick
Copy link
Collaborator Author

Right now it's either/or - not sure they'd play nice together.

I'm considering a source generator with an interceptor that will allow just doing

.AddPages()

and have it decide at compile time what to do. Not sure though....

@Code-DJ
Copy link
Contributor

Code-DJ commented Mar 11, 2024

That's what I thought but the readme makes it look like AddDynamicPages is optional and AddCompiledPages is always required. May be change it to:

.AddDynamicPages() // Remove if you don't have dynamic pages
.AddCompiledPages() // Remove if you are using dynamic pages
;

@twsouthwick
Copy link
Collaborator Author

@Code-DJ here's an issue to track that #250

@twsouthwick twsouthwick enabled auto-merge (squash) March 11, 2024 20:15
Copy link
Collaborator

@birojnayak birojnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general looks ok, but providing little more info would help other users I think... see what you think.

@twsouthwick
Copy link
Collaborator Author

@birojnayak added a bit of more information - feel free to add more if you think it needs it.

@twsouthwick twsouthwick requested a review from birojnayak March 11, 2024 20:46
Copy link
Collaborator

@birojnayak birojnayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twsouthwick twsouthwick merged commit 01411be into main Mar 11, 2024
@twsouthwick twsouthwick deleted the some-docs branch March 11, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants