-
Notifications
You must be signed in to change notification settings - Fork 17
Update some docs for v0.3.0 #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@twsouthwick in the readme, is AddCompiledPages always needed or is it either or? .AddDynamicPages() // Remove if you don't have dynamic pages
.AddCompiledPages(); |
|
Right now it's either/or - not sure they'd play nice together. I'm considering a source generator with an interceptor that will allow just doing and have it decide at compile time what to do. Not sure though.... |
|
That's what I thought but the readme makes it look like AddDynamicPages is optional and AddCompiledPages is always required. May be change it to: .AddDynamicPages() // Remove if you don't have dynamic pages
.AddCompiledPages() // Remove if you are using dynamic pages
; |
birojnayak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general looks ok, but providing little more info would help other users I think... see what you think.
|
@birojnayak added a bit of more information - feel free to add more if you think it needs it. |
birojnayak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.